Skip to content

feat(AddTaskDialog): add DateTimePicker for start field#376

Merged
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
ShivaGupta-14:feat/325-addtaskdialog-start-datetime-picker
Jan 12, 2026
Merged

feat(AddTaskDialog): add DateTimePicker for start field#376
its-me-abhishek merged 1 commit intoCCExtractor:mainfrom
ShivaGupta-14:feat/325-addtaskdialog-start-datetime-picker

Conversation

@ShivaGupta-14
Copy link
Contributor

@ShivaGupta-14 ShivaGupta-14 commented Jan 6, 2026

Description

Checklist

  • Ran npx prettier --write . (for formatting)
  • Ran gofmt -w . (for Go backend)
  • Ran npm test (for JS/TS testing)
  • Added unit tests, if applicable
  • Verified all tests pass
  • Updated documentation, if needed

Additional Notes

Screenshots

Screenshot 2026-01-06 at 4 06 55 PM Screenshot 2026-01-06 at 4 07 03 PM

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Thank you for opening this PR!

Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools.

Please take a moment to:

  • Check the "Files changed" tab
  • Leave comments on any lines for functions, comments, etc. that are important, non-obvious, or may need attention
  • Clarify decisions you made or areas you might be unsure about and/or any future updates being considered.
  • Finally, submit all the comments!

More information on how to conduct a self review:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request

This helps make the review process smoother and gives us a clearer understanding of your thought process.

Once you've added your self-review, we'll continue from our side. Thank you!

ShivaGupta-14
ShivaGupta-14 commented Jan 6, 2026
View reviewed changes
Copy link
Contributor Author

@ShivaGupta-14 ShivaGupta-14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review done, ready for review

@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/325-addtaskdialog-start-datetime-picker branch from 9ab3a49 to 28bb73a Compare January 7, 2026 08:28
This was referenced Jan 8, 2026
Merged
Merged
@ShivaGupta-14
Copy link
Contributor Author

ShivaGupta-14 commented Jan 8, 2026

Hi @its-me-abhishek , thanks for the approval!
Is there anything needed from my side for merging?

@its-me-abhishek its-me-abhishek self-requested a review January 8, 2026 18:26
its-me-abhishek
its-me-abhishek requested changes Jan 8, 2026
View reviewed changes
@ShivaGupta-14
feat(AddTaskDialog): add DateTimePicker for start field
227b376 
- Replace DatePicker with DateTimePicker for start field in AddTaskDialog
- Add DateTimePicker mock in AddTaskDialog.test.tsx
- Add comprehensive tests for DateTime fields (render, update, clear, submit)
- Support both date-only and datetime formats

Contributes: CCExtractor#325
@ShivaGupta-14 ShivaGupta-14 force-pushed the feat/325-addtaskdialog-start-datetime-picker branch from 28bb73a to 227b376 Compare January 8, 2026 21:11
@ShivaGupta-14
Copy link
Contributor Author

ShivaGupta-14 commented Jan 8, 2026

requested changes are done, happy to iterate based on your feedback

@ShivaGupta-14
Copy link
Contributor Author

ShivaGupta-14 commented Jan 9, 2026

@its-me-abhishek could you please review this

@its-me-abhishek its-me-abhishek merged commit 0789dc4 into CCExtractor:main Jan 12, 2026
4 checks passed
@ShivaGupta-14 ShivaGupta-14 deleted the feat/325-addtaskdialog-start-datetime-picker branch January 12, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@its-me-abhishek its-me-abhishek its-me-abhishek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShivaGupta-14 @its-me-abhishek